#4882 Fixed Rows Affected counter for huge numbers (over 2 trillion).

pawelsalawa · Dec 20, 2024 · bf46b3a · bf46b3a
1 parent 287c38e
commit bf46b3a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -3,6 +3,7 @@
 ### 3.4.11
 - CHANGE: SQLite updated to 3.47.2
 - BUGFIX: #5161 An ultimate fix for dialog windows positioning, so they no longer can appear outside of visible screen.
+- BUGFIX: #4882 Fixed Rows Affected counter for huge numbers (over 2 trillion).
 
 ### 3.4.10
 - CHANGE: #5160 The taskbar has been improved to make the currently active task more distinct from the others.

diff --git a/SQLiteStudio3/coreSQLiteStudio/db/abstractdb3.h b/SQLiteStudio3/coreSQLiteStudio/db/abstractdb3.h
@@ -1205,14 +1205,14 @@ int AbstractDb3<T>::Query::fetchFirst()
     for (int i = 0; i < colCount; i++)
         colNames << QString::fromUtf8(T::column_name(stmt, i));
 
-    int changesBefore =  T::total_changes(db->dbHandle);
+    qint64 changesBefore =  T::total_changes64(db->dbHandle);
     rowAvailable = true;
     int res = fetchNext();
 
     affected = 0;
     if (res == T::OK)
     {
-        affected =  T::total_changes(db->dbHandle) - changesBefore;
+        affected =  T::total_changes64(db->dbHandle) - changesBefore;
         insertRowId["ROWID"] = T::last_insert_rowid(db->dbHandle);
     }
 

diff --git a/SQLiteStudio3/coreSQLiteStudio/db/sqlquery.h b/SQLiteStudio3/coreSQLiteStudio/db/sqlquery.h
@@ -302,7 +302,7 @@ class API_EXPORT SqlQuery
          */
         QList<SqlResultsRowPtr> preloadedData;
 
-        int affected = 0;
+        qint64 affected = 0;
 
         QString query;
         QVariant queryArgs;

diff --git a/SQLiteStudio3/coreSQLiteStudio/db/stdsqlite3driver.h b/SQLiteStudio3/coreSQLiteStudio/db/stdsqlite3driver.h
@@ -76,6 +76,7 @@
         static const char *column_origin_name(stmt* arg1, int arg2) {return Prefix##sqlite3_column_origin_name(arg1, arg2);} \
         static int changes(handle* arg) {return Prefix##sqlite3_changes(arg);} \
         static int total_changes(handle* arg) {return Prefix##sqlite3_total_changes(arg);} \
+        static int64 total_changes64(handle* arg) {return Prefix##sqlite3_total_changes(arg);} \
         static int64 last_insert_rowid(handle* arg) {return Prefix##sqlite3_last_insert_rowid(arg);} \
         static int step(stmt* arg) {return Prefix##sqlite3_step(arg);} \
         static int reset(stmt* arg) {return Prefix##sqlite3_reset(arg);} \