Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign a unique name to the React's example #11

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Assign a unique name to the React's example #11

merged 1 commit into from
Jun 30, 2024

Conversation

Andarist
Copy link
Contributor

This resolves part of what can be observed in changesets/changesets#1397

@Andarist
Copy link
Contributor Author

This problem probably would also go away if you'd use bumpVersionsWithWorkspaceProtocolOnly: true but I think this patch is reasonable either way.

@wojtekKrol wojtekKrol changed the base branch from main to dev June 30, 2024 08:02
@wojtekKrol wojtekKrol merged commit 8678d6b into paxcode-it:dev Jun 30, 2024
0 of 2 checks passed
wojtekKrol added a commit that referenced this pull request Jun 30, 2024
@wojtekKrol @Andarist
Dev (#13)
7559695 
* Assign a unique name to the React's example (#11)

* Remove incorrect package glob from the manifest (#12)

* update CI workflow

* add changeset

---------

Co-authored-by: Mateusz Burzyński <[email protected]>
wojtekKrol added a commit that referenced this pull request Jun 30, 2024
@wojtekKrol @Andarist
Dev (#14)
e994710 
* Assign a unique name to the React's example (#11)

* Remove incorrect package glob from the manifest (#12)

* update CI workflow

* add changeset

* update CD workflow

---------

Co-authored-by: Mateusz Burzyński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @wojtekKrol