Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect package glob from the manifest #12

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

Andarist
Copy link
Contributor

This is invalid because u don't have any extra package.json files within src. This would be valid if u'd have some src/*/package.json

Extra context: the root workspace is always included anyway, see https://pnpm.io/pnpm-workspace_yaml :

The root package is always included, even when custom location wildcards are used.

@@ -1,3 +1,2 @@
packages:
- src/*
- examples/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make the root package recognizable as a package for Changesets you should do this:

Suggested change
- examples/*
- .
- examples/*

Traditionally, we ignore root because it's rarely a versionable package

@wojtekKrol wojtekKrol changed the base branch from main to dev June 30, 2024 08:01
@wojtekKrol wojtekKrol merged commit 715f9b5 into paxcode-it:dev Jun 30, 2024
0 of 2 checks passed
wojtekKrol added a commit that referenced this pull request Jun 30, 2024
* Assign a unique name to the React's example (#11)

* Remove incorrect package glob from the manifest (#12)

* update CI workflow

* add changeset

---------

Co-authored-by: Mateusz Burzyński <[email protected]>
wojtekKrol added a commit that referenced this pull request Jun 30, 2024
* Assign a unique name to the React's example (#11)

* Remove incorrect package glob from the manifest (#12)

* update CI workflow

* add changeset

* update CD workflow

---------

Co-authored-by: Mateusz Burzyński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants