Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-9063 Allow Throwing an Exception After Locks for Clone Is Interrupted #31

Conversation

aubi
Copy link

@aubi aubi commented Aug 19, 2024

Rework of HyperWallet PR: hyperwallet#2

Following the EclipseLink ways of coding -- logger, message in resource file, configuration by system properties

Message reported when the exception is thrown, is logged at the SEVERE level as it changes normal behavior.
Other messages are at FINE level not to influence normal execution.

The open question is -- how to reproduce this issue? When this situation (interrupting acquireLocksForClone's waiting) happen?

@Pandrex247
Copy link
Member

Pandrex247 commented Aug 20, 2024

SNAPSHOT of this branch deployed with : mvn clean deploy -DaltDeploymentRepository=payara-nexus-snapshots::https://nexus.dev.payara.fish/repository/payara-snapshots -DskipTests

Cherry-picked to eclipselink-2.7.11.payara-maintenance and deployed with:

git reset --hard HEAD && git clean -ffdx
git fetch https://github.com/payara/patched-src-eclipselink/tree/eclipselink-2.7.11.payara-maintenance
git checkout FETCH_HEAD
git checkout -b FISH-9063-Ent5
git cherry-pick a296980c0fd9bcb2d125978e953589d2fa49cc7b
// Resolve conflicts...
export PATCH_VERSION=5-SNAPSHOT
export REPO=~/.m2/repository
export M2_HOME=${MAVEN_HOME}
bash ./payara-build.sh prepare
bash ./payara-build.sh compile
bash ./payara-build.sh install
ant -f uploadToNexus.xml -Dmavenant.dir=target/ -Drelease.version=2.7.11.payara-p5 -Dbuild.type=SNAPSHOT -Dgit.hash=`git rev-parse --short HEAD` -Dversion.string=2.7.11.payara-p5-SNAPSHOT -Dmaven.repo.dir=~/.m2/repository -Dmaven.repo.url=https://nexus.dev.payara.fish/repository/payara-snapshots -DstagingId=payara-nexus-snapshots -DstagingURL=https://nexus.dev.payara.fish/repository/payara-artifacts -Dasm.version=2.7.11.payara-p5 -DsnapshotId=payara-nexus-snapshots -DsnapshotURL=https://nexus.dev.payara.fish/repository/payara-snapshots

Note, this upload is really janky, as it uploads the artefact, sources, and javadoc as separate snapshots. The script or ant script is clearly wrong, as they should all clearly be one snapshot.

@aubi aubi marked this pull request as ready for review September 6, 2024 07:42
@aubi aubi merged commit 5aad3f7 into payara:eclipselink-4.0.1.payara-maintenance Sep 11, 2024
@aubi aubi deleted the FISH-9063-allow-throw-after-interrupted-locks-for-clone branch September 11, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants