Cleanup test assertions #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves legibility by having tokio::select! return the test result and calling `assert!` as a distinct step.
Pull Request Test Coverage Report for Build 13059546986Details
💛 - Coveralls |
nothingmuch
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Apologies for the delay. utACK.
Yes, this addresses the specific problem I had encountered. Whether or not it should close the issue is debatable, depending on whether or not we want to systematically go looking for other examples, I'm happy to close it and open new specific issues as they come up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit aims to fix #421 - @nothingmuch is this close to what you had in mind?
The second commit mostly just improves legibility on integration/e2e test assertions.