Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prevent tsconfig.base.json from changing for dev and e2e #10228

Closed
wants to merge 4 commits into from

Conversation

r1tsuu
Copy link
Member

@r1tsuu r1tsuu commented Dec 28, 2024

Prevents tsconfig.base.json from changing every time you run dev / e2e, instead testHooks.ts writes gitignored tsconfig.generated.json (from tsconfig.base.json). Adds it to extends to the root tsconfig.json file and so compilerOptions.paths (which is needed for @payload-config) from tsconfig.generated.json overrides tsconfig.base.json.

@r1tsuu r1tsuu force-pushed the lock-tsconfig-from-changing branch from 48ecd8a to dce8a37 Compare December 28, 2024 19:47
Copy link

socket-security bot commented Dec 28, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint/[email protected] filesystem, unsafe 0 680 kB eslintbot
npm/@payloadcms/[email protected] environment, filesystem, network Transitive: shell +26 11.9 MB elliotpayload
npm/@payloadcms/[email protected] environment, filesystem, network 0 482 kB elliotpayload
npm/@payloadcms/[email protected] Transitive: environment, filesystem, network, shell +1 522 kB elliotpayload
npm/@payloadcms/[email protected] None +4 1.27 MB elliotpayload
npm/@payloadcms/[email protected] Transitive: network +1 80.2 kB elliotpayload
npm/@payloadcms/[email protected] Transitive: environment, filesystem, network, shell, unsafe +108 46.5 MB elliotpayload
npm/@payloadcms/[email protected] Transitive: environment +3 4.8 MB elliotpayload
npm/@payloadcms/[email protected] environment, filesystem, network Transitive: shell +97 8.66 MB elliotpayload
npm/@payloadcms/[email protected] None 0 177 kB elliotpayload
npm/@payloadcms/[email protected] None 0 46.1 kB elliotpayload
npm/@payloadcms/[email protected] None 0 16.4 kB elliotpayload
npm/@payloadcms/[email protected] None 0 99.3 kB elliotpayload
npm/@payloadcms/[email protected] None +1 2.61 MB elliotpayload
npm/@payloadcms/[email protected] environment Transitive: unsafe +116 44.6 MB elliotpayload
npm/@payloadcms/[email protected] environment +1 7.11 MB elliotpayload
npm/@payloadcms/[email protected] environment, network Transitive: filesystem, unsafe +112 175 MB elliotpayload
npm/@payloadcms/[email protected] environment, network +2 11.8 MB elliotpayload
npm/@radix-ui/[email protected] None +10 183 kB chancestrickland
npm/@radix-ui/[email protected] None +1 30.3 kB vladmoroz
npm/@radix-ui/[email protected] None +24 770 kB chancestrickland
npm/@radix-ui/[email protected] None +1 33.2 kB vladmoroz
npm/@swc/[email protected] environment, filesystem, shell +2 197 kB kdy1
npm/@tailwindcss/[email protected] None 0 110 kB adamwathan
npm/@types/[email protected] None 0 16.9 kB types
npm/@types/[email protected] None 0 4.45 kB types
npm/@types/[email protected] None 0 2.2 MB types
npm/[email protected] environment Transitive: filesystem, shell +6 76 kB kentcdodds
npm/[email protected] environment, filesystem 0 23.9 kB motdotla
npm/[email protected] eval, filesystem Transitive: environment, shell +15 1.35 MB mde
npm/[email protected] unsafe Transitive: environment, eval, filesystem +181 23.5 MB vercel-release-bot
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +98 10.8 MB eslintbot
npm/[email protected] environment 0 1.36 MB benjie
npm/[email protected] filesystem Transitive: environment, network +35 5.83 MB jrit
npm/[email protected] environment, filesystem, network, shell, unsafe +13 122 MB vercel-release-bot
npm/[email protected] environment, eval, filesystem, network, shell, unsafe +85 147 MB elliotpayload
npm/[email protected] environment +1 6.45 MB react-bot
npm/[email protected] environment 0 239 kB react-bot
npm/[email protected] Transitive: environment, filesystem, network, shell +3 680 kB hirokiosame
npm/[email protected] None 0 17.7 kB eps1lon
npm/[email protected] None +1 1.63 MB eps1lon
npm/[email protected] None 0 21.9 MB typescript-bot

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Dec 28, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Possible typosquat attack npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@r1tsuu r1tsuu marked this pull request as ready for review December 28, 2024 20:27
@r1tsuu r1tsuu requested a review from denolfe as a code owner December 28, 2024 20:27
@r1tsuu r1tsuu closed this Dec 28, 2024
@r1tsuu r1tsuu deleted the lock-tsconfig-from-changing branch December 28, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant