fix(ui): properly instantiates abort controllers #10309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
added a commit
that referenced
this pull request
Jan 2, 2025
Fixes #10296. When an async `useEffect` runs twice or more before resolving, we use the Abort Controller API to cancel previous events. This works by instantiating a new ref on each run, and if a previous ref was detected, it will be aborted and a new instance will be set up for the next run. However, while the logic was aborting previous instances as expected, it was failing to instantiate a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10296. When an async
useEffectruns twice or more before resolving, we use the Abort Controller API to cancel previous events. This works by instantiating a new ref on each run, and if a previous ref was detected, it will be aborted and a new instance will be set up for the next run. However, while the logic was aborting previous instances as expected, it was failing to instantiate a new one.