fix(ui): fixed many bugs in the WhereBuilder relationship select menu #10553
+123
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
commented
Jan 13, 2025
Comment on lines
-80
to
+88
| depth?: number | ||
| limit?: number | ||
| page?: number | ||
| where: Where | ||
| } = { | ||
| const query = { | ||
| depth: 0, | ||
| limit: maxResultsPerRequest, | ||
| page: pageIndex, | ||
| select: { | ||
| [fieldToSearch]: true, | ||
| }, | ||
| where: { | ||
| and: [], | ||
| }, | ||
| } as Where, |
There was a problem hiding this comment.
- simplified types using inference when possible
- use select to bring only the field we are interested in
GermanJablo
commented
Jan 13, 2025
Comment on lines
+116
to
+122
| if (data.nextPage) { | ||
| nextPageByRelationshipRef.current.set(relationSlug, data.nextPage) | ||
| } else { | ||
| partiallyLoadedRelationshipSlugs.current = | ||
| partiallyLoadedRelationshipSlugs.current.filter( | ||
| (partiallyLoadedRelation) => partiallyLoadedRelation !== relationSlug, | ||
| ) |
There was a problem hiding this comment.
If we leave the if (!debounceSearch), when we reach the end of the scroll, the results will start repeating to infinity.
Note that the setting of the two refs must occur even if nothing is written in the search input.
GermanJablo
commented
Jan 13, 2025
| @@ -209,7 +205,9 @@ export const RelationshipField: React.FC<Props> = (props) => { | |||
| }, [hasMany, hasMultipleRelations, value, options]) | |||
|
|
|||
| const handleInputChange = (input: string) => { | |||
| dispatchOptions({ type: 'CLEAR', i18n, required: false }) | |||
There was a problem hiding this comment.
If this line is not added, when writing something the results that are in the select will not disappear, even if they do not meet the new search term.
GermanJablo
commented
Jan 13, 2025
| const relationSlug = partiallyLoadedRelationshipSlugs.current[0] | ||
| partiallyLoadedRelationshipSlugs.current = relationSlugs |
There was a problem hiding this comment.
Both refs are reset to the initial values of the component.
If this line is not added, when scrolling to a last page, nothing else can be searched again.
GermanJablo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #10551, I found and fixed a handful more bugs: