fix(ui): thread cache tag to list view thumbnails #11741
+40
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Check if the fileSrc already has a query string, if it does, append the imageCacheTag with an ampersand | ||
| */ | ||
| const queryChar = fileSrc?.includes('?') ? '&' : '?' | ||
| return imageCacheTag ? `${fileSrc}${queryChar}${encodeURIComponent(imageCacheTag)}` : fileSrc |
There was a problem hiding this comment.
I believe this will encode false for no reason here? We should first check for the cache tag.
There was a problem hiding this comment.
Hey @JarrodMFlesch
Thanks for reviewing!
I think if imageCacheTag is false-y (or straight up false), then this code will fallback to fileSrc. If no fileSrc is provided, then it returns early with null unless I missed something here. Note the ternary operator in the return there. Am I overlooking a case?
Let me know!
| * Check if the fileSrc already has a query string, if it does, append the imageCacheTag with an ampersand | ||
| */ | ||
| const queryChar = fileSrc?.includes('?') ? '&' : '?' | ||
| return imageCacheTag ? `${fileSrc}${queryChar}${encodeURIComponent(imageCacheTag)}` : fileSrc |
There was a problem hiding this comment.
I believe this will encode false for no reason here? We should first check for the cache tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR threads a cache tag to the
Thumbnailcomponent through the defaultFilecell in the list view if cache tags are enabled in upload config. These changes also adjust theThumbnailcomponent to useuseMemoinstead of constructing asrclater due to:The above causes an extra request to be made if cache tags are enabled.
Why?
To thread cache tags through to the list view thumbnails.
How?
Changes the default
Filecell to pass the cache tag through if enabled, and changing a failing test to accommodate cache tags in the list view.Addresses cache tag issue in #11690