fix(ui): error after clearing selected collection in ListDrawer when multiple collections are available #12276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The ListDrawer renders a list view for one or many collections. In the case where the drawer is rendering the list view for many collections (such as in the case of polymorphic relations) it is possible to clear the selected relationship from the select component in the ui, which throws an error as the renderList function expects a slug.
How?
This fix sets isClearable to 'false' in the ReactSelect component so that there is always a value passed in to the renderList function. I suppose an alternative would be to add logic to handle a null value being passed in to the renderList function, but I can't think of a case when we would ever not want to render a list in the ListDrawer so I think simply setting isClearable to 'false' should be enough.