perf: added inline relationships (use JOINs instead of SELECTs) #14152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjgtav
commented
Oct 10, 2025
| if ((isFieldLocalized || parentIsLocalized) && _locales) { | ||
| _locales.columns = _locales.columns || ({} as Result['columns']) | ||
| _locales.columns[fieldPath] = true | ||
| } else if (adapter.tables[currentTableName]?.[fieldPath]) { |
There was a problem hiding this comment.
I don't use localization in my setup yet, so I'm not sure how correct this is.
I wrote it based on samples from other places in the file
rjgtav
commented
Oct 10, 2025
| if ((isFieldLocalized || parentIsLocalized) && _locales) { | ||
| _locales.with = _locales.with || {} | ||
| _locales.with[fieldPath] = true | ||
| } else { |
There was a problem hiding this comment.
I don't use localization in my setup yet, so I'm not sure how correct this is.
I wrote it based on samples from other places in the file
rjgtav
commented
Oct 10, 2025
| : { id: false, _parentID: false }, | ||
| with: {}, | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't use localization in my setup yet, so I'm not sure how correct this is.
I wrote it based on samples from other places in the file
rjgtav
commented
Oct 10, 2025
| Object.keys(withRelationship.with._locales.columns).length === 1 | ||
| ) { | ||
| delete withRelationship.with._locales | ||
| } |
There was a problem hiding this comment.
I don't use localization in my setup yet, so I'm not sure how correct this is.
I wrote it based on samples from other places in the file
rjgtav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the ability to inline relationships (i.e. use JOINs instead of separate SELECTs when fetching from the database).
This is controlled by a new
inlineflag that can be enabled when defining a relationship/upload field.This feature works particularly well when used alongside the
selectparameter.Why?
To reduce the total number of database queries that are generated when fetching, saving or updating collections. This is particularly impactful on collections with multiple relationship/upload fields. I've seen it reduce from 15-30 queries to the database in a single operation to just 5-10.
How?
By configuring Drizzle to join with the related collection, via the
withparameter.