fix(plugin-nested-docs): allow placing breadcrumbs & parent in tabs field by properly flattening collection fields #14192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tangentially related to this PR: Even though this change lets me put the relevant fields in a tab, I would ideally still have them appear in the sidebar but only while on the configured tab. It seems like if a field is in a tab, the admin.sidebar option doesn't do anything. |
BrannanKovachev
changed the title
BrannanKovachev
changed the title
BrannanKovachev
force-pushed
the
bkovachev/nested-tabs
branch
from
acba582 to
5159c6d
Compare
BrannanKovachev
force-pushed
the
bkovachev/nested-tabs
branch
from
5159c6d to
c494315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Previously, if you were using the nested docs plugin and made use of the createParentField or createBreadcrumbsField functions in the collection where nested docs is enabled, you could not place either the of those in a "tabs" field.
Why?
The issue happens because the code did not search the flattened fields of the collection. In other words, it wouldn't search within 'tabs' type fields for a field matching the desired namee.
How?
We flatten the fields and then search them.