Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctrl s on global section #3342

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Fix ctrl s on global section #3342

merged 3 commits into from
Oct 11, 2023

Conversation

limistah
Copy link

Description

Fixes Issue #3336

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@JarrodMFlesch
Copy link
Contributor

This has been fixed on the 2.0 branch, if you want to make the same fix here we can merge that in! https://github.com/payloadcms/payload/blob/2.0/packages/payload/src/admin/components/views/Global/index.tsx#L105

Basically you just need to move the EditDepth provider up one level.

Looks like your branch needs to merge master changes in also. LMK if this makes sense!

@limistah
Copy link
Author

limistah commented Oct 5, 2023

Yes, it does.

I think it should be supported on here as well.

I'll make the changes.

@limistah
Copy link
Author

limistah commented Oct 5, 2023

Changes have been made.

@denolfe denolfe added the base: 1.x PR targets old 1.x branch label Oct 10, 2023
@JarrodMFlesch JarrodMFlesch merged commit 5f6a0db into payloadcms:1.x Oct 11, 2023
1 of 3 checks passed
@JarrodMFlesch
Copy link
Contributor

Thanks @limistah! Merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: 1.x PR targets old 1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cmd + S hotkey doesn't work sometimes due to editDepth check
3 participants