Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-form-builder): use escapeHTML on submission data in serializeLexical #8110

Merged

Conversation

NorthBlue333
Copy link

@NorthBlue333 NorthBlue333 commented Sep 7, 2024

Description

Fixes #8109
Note this should also be merge in payload/beta!

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes

@AlessioGr AlessioGr changed the title fix: use escapeHTML on submission data in serializeLexical fix(plugin-form-builder): use escapeHTML on submission data in serializeLexical Sep 25, 2024
@DanRibbens DanRibbens added the keep label Dec 6, 2024
@DanRibbens DanRibbens merged commit b0de37b into payloadcms:2.x Dec 6, 2024
34 of 35 checks passed
@denolfe denolfe removed the stale label Dec 6, 2024
@DanRibbens
Copy link
Contributor

The CI tests are failing on the v3 PR #9799 with these changes. I am going to revert this to give pause on the changes without further testing and understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin-form-builder][security] Submission data in emails is never escaped with serializeLexical
4 participants