Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload.defParamCharset: utf8 by default #8157

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

r1tsuu
Copy link
Member

@r1tsuu r1tsuu commented Sep 10, 2024

Description

Fixes #8107

This has been confusing for people from countries where characters aren't latin, for example the Japanese file name:
フェニックス.png
Turns into:
ãã§ããã¯ã¹.png

Additionally, ensures type-safety for DEFAULT_OPTIONS and removes unused fileHandler property from there, which isn't defined in the FetchAPIFileUploadOptions type.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@r1tsuu r1tsuu enabled auto-merge (squash) September 10, 2024 17:39
@r1tsuu r1tsuu merged commit a234092 into beta Sep 10, 2024
56 checks passed
@r1tsuu r1tsuu deleted the fix/upload-utf-8-default branch September 10, 2024 17:40
Copy link
Contributor

🚀 This is included in version v3.0.0-beta.103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants