Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return type of findByID with strict: true #8953

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

r1tsuu
Copy link
Member

@r1tsuu r1tsuu commented Oct 30, 2024

What?

Corrects the return type of findByID when strict: true / strictNullChecks: true is used, adds null to the return type only when disableErrors: true is passed.

image
image

@r1tsuu r1tsuu changed the title fix: return type of findByID and disableErrors fix: return type of findByID when having strict: true Oct 30, 2024
@r1tsuu r1tsuu changed the title fix: return type of findByID when having strict: true fix: return type of findByID with strict: true Oct 30, 2024
@r1tsuu r1tsuu merged commit 08251ec into beta Oct 31, 2024
58 checks passed
@r1tsuu r1tsuu deleted the fix/findByID-disable-errors-null branch October 31, 2024 01:11
Copy link
Contributor

🚀 This is included in version v3.0.0-beta.123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant