fix(ui): properly animates height for dynamically rendered children #9665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9567. When using the
AnimateHeightcomponent on a patched browser such as Webkit, components with dynamically rendered children are not properly animating in, such as blocks with rich text. This is because the height of that content is unable to be calculated before it's rendered, preventing the component from acquiring a target height to animate toward. This change was originally introduced in #9456 in effort to remove unnecessary dependencies.The fix is to setup a ResizeObserver during animation to watch for changes to the content's height. This way, as components dynamically render in based on the "open" state, the hook will simply increment the target height accordingly.