fix: ensures autosaves run sequentially rather than ever in parallel #9809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, [isProcessing, queue]) | ||
|
|
||
| // Process the queue whenever it changes | ||
| useEffect(() => { |
There was a problem hiding this comment.
Can we do this without a useEffect? Seems like it should be possible
There was a problem hiding this comment.
Maybe it cant, I hate it but will live
There was a problem hiding this comment.
Can't you just call processCurrentAutosave and have it take the autosave function as an arg and leave everything else as it is? Removing the autosave state and the useEffect?
|
Should update the description here, I think your initial commit allowed them to fire sequentially but now it just allows 1 to run and future autosaves cannot be called if the prev one has not finished. |
|
Closing in favor of #9892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a small autosave interval, it's possible for two autosaves to be executing in parallel.
This PR ensures that you can fire many autosaves, but they will be executed sequentially rather than ever being able to be run in parallel.