Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#61] Make NNA constructor that accepts configuration #76

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

pjeli
Copy link
Collaborator

@pjeli pjeli commented Jul 13, 2018

Make sure you have checked all steps below.

GitHub Issue

Fixes #61

Checklist:

  • This pull request updates the documentation
  • This pull request changes the code
  • Title of the PR is of format (example) : [#25] Add Pull Request Template, where [#25] is the GitHub issue number

What is the purpose of this pull request?

How was this change validated?

Commit Guidelines

  • My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@pjeli pjeli self-assigned this Jul 13, 2018
@pjeli pjeli force-pushed the bootstrap_refactor branch from 17844ea to 65ee5e8 Compare July 13, 2018 21:59
@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #76 into master will decrease coverage by 0.25%.
The diff coverage is 42.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
- Coverage      54.5%   54.25%   -0.26%     
+ Complexity      568      563       -5     
============================================
  Files            34       34              
  Lines          4216     4208       -8     
  Branches        402      399       -3     
============================================
- Hits           2298     2283      -15     
- Misses         1738     1747       +9     
+ Partials        180      178       -2
Impacted Files Coverage Δ Complexity Δ
...ava/com/paypal/security/SecurityConfiguration.java 58.82% <100%> (-4.82%) 16 <1> (-1)
...n/java/com/paypal/namenode/NNAnalyticsRestAPI.java 37.47% <39.53%> (-0.46%) 48 <3> (-2)
...g/apache/hadoop/hdfs/server/namenode/NNLoader.java 64.91% <0%> (-0.42%) 280% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d25e598...65ee5e8. Read the comment docs.

@pjeli pjeli merged commit 1e60c6a into master Jul 13, 2018
@pjeli pjeli deleted the bootstrap_refactor branch July 13, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant