Remove venmoAppLabel experiment (#2231)

paypal · Sep 6, 2023 · c27574e · c27574e
1 parent 9227d40
commit c27574e
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 59 deletions.
diff --git a/src/funding/venmo/config.jsx b/src/funding/venmo/config.jsx
@@ -11,7 +11,7 @@ import { PLATFORM } from "@paypal/sdk-constants/src";
 import { BUTTON_COLOR, BUTTON_LAYOUT } from "../../constants";
 import { DEFAULT_FUNDING_CONFIG, type FundingSourceConfig } from "../common";
 
-import { WalletLabel, Label, AppLabel } from "./template";
+import { WalletLabel, Label } from "./template";
 
 export function getVenmoConfig(): FundingSourceConfig {
   return {
@@ -55,9 +55,6 @@ export function getVenmoConfig(): FundingSourceConfig {
     },
 
     Label: ({ ...props }) => {
-      if (props.experiment && props.experiment.enableVenmoAppLabel) {
-        return AppLabel(props);
-      }
       return Label(props);
     },
 

diff --git a/src/funding/venmo/template.jsx b/src/funding/venmo/template.jsx
@@ -15,23 +15,6 @@ import { Text, Space } from "../../ui/text";
 
 import css from "./style.scoped.scss";
 
-export function AppLabel(opts: LabelOptions): ChildType {
-  const { logoColor } = opts;
-
-  const AppLogo: ChildType = (
-    <Style css={css}>
-      {__WEB__ ? (
-        <VenmoLogoExternalImage logoColor={logoColor} />
-      ) : (
-        <VenmoLogoInlineSVG logoColor={logoColor} />
-      )}
-      <Text className={["app-label"]}>App</Text>
-    </Style>
-  );
-
-  return <BasicLabel {...opts} logo={AppLogo} />;
-}
-
 export function Label(opts: LabelOptions): ChildType {
   return <BasicLabel {...opts} />;
 }

diff --git a/src/types.js b/src/types.js
@@ -59,7 +59,6 @@ export type ContentType = {|
 export type Experiment = {|
   enableVenmo?: boolean,
   disablePaylater?: boolean,
-  enableVenmoAppLabel?: boolean,
   venmoWebEnabled?: boolean,
 |};
 

diff --git a/src/zoid/buttons/util.js b/src/zoid/buttons/util.js
@@ -11,19 +11,17 @@ import {
   isDevice,
   isTablet,
   getElement,
-  isLocalStorageEnabled,
   isStandAlone,
   once,
 } from "@krakenjs/belter/src";
-import { ENV, FUNDING } from "@paypal/sdk-constants/src";
+import { FUNDING } from "@paypal/sdk-constants/src";
 import {
   getEnableFunding,
   getLogger,
   createExperiment,
   getFundingEligibility,
   getPlatform,
   getComponents,
-  getEnv,
 } from "@paypal/sdk-client/src";
 import { getRefinedFundingEligibility } from "@paypal/funding-components/src";
 
@@ -175,21 +173,6 @@ export function getVenmoExperiment(): EligibilityExperiment {
   }
 }
 
-export function getVenmoAppLabelExperiment(): EligibilityExperiment {
-  const isEnvForTest =
-    getEnv() === ENV.LOCAL || getEnv() === ENV.TEST || getEnv() === ENV.STAGE;
-
-  let isEnabledForTest = false;
-
-  if (isLocalStorageEnabled() && isEnvForTest) {
-    isEnabledForTest = window.localStorage.getItem("enable_venmo_app_label");
-  }
-
-  return {
-    enableVenmoAppLabel: isEnabledForTest,
-  };
-}
-
 export function getRenderedButtons(
   props: ButtonProps
 ): $ReadOnlyArray<$Values<typeof FUNDING>> {
@@ -322,7 +305,6 @@ export function applePaySession(): ?ApplePaySessionConfigRequest {
 export function getButtonExperiments(): EligibilityExperiment {
   return {
     ...getVenmoExperiment(),
-    ...getVenmoAppLabelExperiment(),
   };
 }
 

diff --git a/test/integration/tests/button/eligibility.js b/test/integration/tests/button/eligibility.js
@@ -42,7 +42,7 @@ describe("venmo button eligibility", () => {
         test: {
           onRender: expect("onRender", ({ xprops, fundingSources }) => {
             const {
-              experiment: { enableVenmo, enableVenmoAppLabel, venmoWebEnabled },
+              experiment: { enableVenmo, venmoWebEnabled },
             } = xprops;
             if (!enableVenmo) {
               throw new Error(
@@ -60,14 +60,6 @@ describe("venmo button eligibility", () => {
               );
             }
 
-            if (enableVenmoAppLabel) {
-              throw new Error(
-                `Expected enableVenmoAppLabel experiment to not be eligible: ${JSON.stringify(
-                  xprops.experiment
-                )}`
-              );
-            }
-
             if (!fundingSources.includes(FUNDING.VENMO)) {
               throw new Error(
                 `Venmo is missing from the list of funding sources: ${fundingSources}`
@@ -102,7 +94,7 @@ describe("venmo button eligibility", () => {
         test: {
           onRender: expect("onRender", ({ xprops, fundingSources }) => {
             const {
-              experiment: { enableVenmo, enableVenmoAppLabel },
+              experiment: { enableVenmo },
             } = xprops;
             if (!enableVenmo) {
               throw new Error(
@@ -112,14 +104,6 @@ describe("venmo button eligibility", () => {
               );
             }
 
-            if (!enableVenmoAppLabel) {
-              throw new Error(
-                `Expected enableVenmoAppLabel experiment to be eligible: ${JSON.stringify(
-                  xprops.experiment
-                )}`
-              );
-            }
-
             if (!fundingSources.includes(FUNDING.VENMO)) {
               throw new Error(
                 `Venmo is missing from the list of funding sources: ${fundingSources}`