-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support New displayOnly Confg Option #2252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get a unit test up for src/funding/funding.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking swell sir!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2252 +/- ##
==========================================
- Coverage 51.22% 51.01% -0.21%
==========================================
Files 104 104
Lines 2007 2025 +18
Branches 587 599 +12
==========================================
+ Hits 1028 1033 +5
- Misses 879 889 +10
- Partials 100 103 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Description
This PR uses the new
displayOnly
config option in the button eligibility logic.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Jira: https://paypal.atlassian.net/browse/DTPPCPSDK-825
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!