Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support New displayOnly Confg Option #2252

Merged
merged 12 commits into from
Oct 17, 2023

Conversation

spencersablan
Copy link
Contributor

@spencersablan spencersablan commented Sep 29, 2023

Description

This PR uses the new displayOnly config option in the button eligibility logic.

paypal.Buttons({
    displayOnly: ["vaultable"]
})

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

Jira: https://paypal.atlassian.net/browse/DTPPCPSDK-825

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

@spencersablan
Copy link
Contributor Author

Lint is failing because it doesn't have the new constant I added to paypal-sdk-constants.
image

Copy link
Member

@wsbrunson wsbrunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get a unit test up for src/funding/funding.js

src/funding/funding.js Outdated Show resolved Hide resolved
@spencersablan spencersablan marked this pull request as ready for review October 13, 2023 16:35
@spencersablan spencersablan requested a review from a team as a code owner October 13, 2023 16:35
Copy link
Member

@wsbrunson wsbrunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking swell sir!

src/funding/funding.test.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c27574e) 51.22% compared to head (1624c81) 51.01%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   51.22%   51.01%   -0.21%     
==========================================
  Files         104      104              
  Lines        2007     2025      +18     
  Branches      587      599      +12     
==========================================
+ Hits         1028     1033       +5     
- Misses        879      889      +10     
- Partials      100      103       +3     
Flag Coverage Δ
jest 31.99% <23.52%> (-0.10%) ⬇️
karma 49.66% <27.27%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/ui/buttons/buttons.jsx 76.71% <ø> (ø)
src/ui/buttons/props.js 78.49% <100.00%> (+0.23%) ⬆️
src/zoid/buttons/component.jsx 81.25% <100.00%> (+0.19%) ⬆️
src/funding/funding.js 67.12% <18.75%> (-13.58%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spencersablan spencersablan merged commit bcd4e50 into main Oct 17, 2023
2 of 3 checks passed
@spencersablan spencersablan deleted the feature/DTPPCPSDK-825-paylater-vault branch October 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants