Include branded in HCF eligibility check #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethmv
force-pushed
the
bcdc-hcf-render-issue
branch
from
e5b8bbc to
fff642f
Compare
wsbrunson
approved these changes
Oct 12, 2023
|
testing these zoid components is extremely difficult, we'll come back with unit tests once we have more time |
wsbrunson
force-pushed
the
bcdc-hcf-render-issue
branch
from
fff642f to
4fc779f
Compare
elizabethmv
force-pushed
the
bcdc-hcf-render-issue
branch
from
4fc779f to
d2e844d
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
=======================================
Coverage 51.22% 51.22%
=======================================
Files 104 104
Lines 2007 2007
Branches 587 587
=======================================
Hits 1028 1028
Misses 879 879
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will mark HCF ineligible if branded card is eligible
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Branded card fields and unbranded card fields should not render together
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
N/A
Groups who should review (if applicable)
@cgdibble @siddy2181