Revert Vault with Purchase on Client #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KunJeongPark
changed the title
1 task
sshropshire
approved these changes
Aug 2, 2023
jaxdesmarais
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Do we also want to remove the Vault.swift file as well as the vault objects from ConfirmPaymentSourceRequest
|
Hi @jaxdesmarais I think vault objects are removed from |
jaxdesmarais
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As of now, plan is for merchant to implement this on their server side
because of issues with a merchant integration pattern that requires authentication to be
passed from server side
Checklist
Authors