(fix) proxy function props to prevent stale state in callbacks #604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
Callback props (e.g.
createOrder
,onApprove
) are passed topaypal.Buttons
in a useEffect, where the SDK Button component is then rendered. While the SDK provides aforceReRender
prop to re-invoke the effect, which will update the callback functions passed to the SDK Button, this renders the SDK again (triggering animations, etc). The SDK Button otherwise never receives new functions as the parent component updates, creating stale closures.change
This PR provides a stable object from which to read the callback functions without requiring an SDK re-render.
resolves #590