Change to MODAL_VIEWED

paypal · Apr 12, 2024 · bd9c0b7 · bd9c0b7
1 parent ababf62
commit bd9c0b7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/library/src/main/java/com/paypal/messages/ModalFragment.kt b/library/src/main/java/com/paypal/messages/ModalFragment.kt
@@ -325,7 +325,7 @@ internal class ModalFragment(
 
 	// This function is called when the modal is usually already instantiated
 	override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
-		logEvent(AnalyticsEvent(eventType = EventType.MODAL_OPENED))
+		logEvent(AnalyticsEvent(eventType = EventType.MODAL_VIEWED))
 		this.onLoading()
 		val url = Api.createModalUrl(clientId, amount, buyerCountry, offerType)
 

diff --git a/library/src/main/java/com/paypal/messages/analytics/EventType.kt b/library/src/main/java/com/paypal/messages/analytics/EventType.kt
@@ -5,7 +5,7 @@ enum class EventType {
 	MESSAGE_CLICKED,
 	MODAL_RENDERED,
 	MODAL_CLICKED,
-	MODAL_OPENED,
+	MODAL_VIEWED,
 	MODAL_CLOSED,
 	MODAL_ERROR,
 	;

diff --git a/library/src/test/java/com/paypal/messages/analytics/EventTypeTest.kt b/library/src/test/java/com/paypal/messages/analytics/EventTypeTest.kt
@@ -26,7 +26,7 @@ class EventTypeTest {
 
 	@Test
 	fun testModalOpen() {
-		assertEquals(EventType.MODAL_OPENED.toString(), "modal_opened")
+		assertEquals(EventType.MODAL_VIEWED.toString(), "modal_opened")
 	}
 
 	@Test
-Original file line number
+Diff line change
@@ Expand Up / @@ -26,7 +26,7 @@ class EventTypeTest { @@
     	@Test
     	fun testModalOpen() {
-    		assertEquals(EventType.MODAL_OPENED.toString(), "modal_opened")
+    		assertEquals(EventType.MODAL_VIEWED.toString(), "modal_opened")
     	}
     	@Test
@@ Expand Down @@