Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Package Pre-Release #14
feat: Package Pre-Release #14
Changes from 60 commits
a6bc34c
fd1f625
e0a68c4
068748e
b26570a
3e2c56c
c9f24f3
03c10b5
0141739
31c1524
82ce7fa
8d70d51
2baa4c1
ead9d89
683d9fd
f4dced6
c4bbffb
d4cae59
073dcb7
bb8fb9a
f31b56a
e903ddb
3a4945f
32c1d97
6195470
170a48f
5f469c7
a96670a
048a30a
96e0f5d
706fce2
fc7bc24
a186dbd
ce4c870
48b7f3f
5796291
df28180
70d7b12
0ec0588
89c7a04
cbd35e5
31a8005
265dcea
84e58b8
639efbb
2482aea
4e8ba41
a3ae992
a9fe7d2
e5d0a4d
d7f2160
b39a163
e70fc54
d398c64
1f3723d
7ebcde0
336d203
13bfa58
f745ebc
9fa5c5d
03f18f3
fbf3d68
eb9c78e
f8f4315
4926e94
c74f8d6
f12bc80
e674538
06bc1f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's spell out
sonatype_usr
,sonatype_pwd
, andsigning_key_pwd
instead of abbreviating for clarity sakeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're using this as part of our release step, let's create a separate job for building the demo. While the demo isn't needed for releases, we do want to ensure it's buildable on each PR.
This also means that the strategy matrix in this job can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created separate job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we only have the one module, we should be able to just call
./gradlew --stacktrace assemble :library:assemble
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want to keep a GitHub release in line with our published packages, so these should stick around in some fashion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm checking with Steven on the difference but if we're updating the distribution here, we should probably update it everywhere for consistency
Steven said it shouldn't matter which one we use, but since that team is using Microsoft, let's switch it everywhere to Microsoft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it says "Publish to Maven" but above it says "Publish to Sonatype". Why the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I didn't see name when I updated it. I'll make them align
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these module and version variables used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used. Removing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the version as a hardcoded string in 4 places. Is there a way we can define the version in one place and use a variable everywhere else?
We also have 1.0.1-SNAPSHOT above in
buildscript
. Should that be the same version as here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defined in 1 place