(fix) loadV4 loader loads latest checkout.js

paypal · May 30, 2024 · d29f319 · d29f319
1 parent 48718ca
commit d29f319
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/server/meta.jsx b/server/meta.jsx
@@ -356,7 +356,7 @@ export function unpackSDKMeta(sdkMeta?: string): SDKMeta {
                                 return;
                             }
 
-                            if (version === '4' || version === 'latest') {
+                            if (version === 'latest' || version.charAt(0) === '4') {
                                 version = '';
                             }
 

diff --git a/server/meta.test.js b/server/meta.test.js
@@ -255,7 +255,7 @@ test("should construct a valid versioned script url with paypalobjects", () => {
 });
 
 test("should construct a valid versioned minified script url with paypalobjects", () => {
-  const sdkUrl = "https://www.paypalobjects.com/api/checkout.4.0.125.min.js";
+  const sdkUrl = "https://www.paypalobjects.com/api/checkout.min.js";
 
   const { getSDKLoader } = unpackSDKMeta(
     Buffer.from(
@@ -809,7 +809,7 @@ test("should construct a valid minified loader even when no url passed", () => {
 });
 
 test("should construct a valid version loader even when no url passed", () => {
-  const sdkUrl = "https://www.paypalobjects.com/api/checkout.4.0.435.js";
+  const sdkUrl = "https://www.paypalobjects.com/api/checkout.js";
 
   const { getSDKLoader } = unpackSDKMeta();
-Original file line number
+Diff line change
@@ Expand Up / @@ -356,7 +356,7 @@ export function unpackSDKMeta(sdkMeta?: string): SDKMeta { @@
                                     return;
                                 }
-                                if (version === '4' || version === 'latest') {
+                                if (version === 'latest' || version.charAt(0) === '4') {
                                     version = '';
                                 }
@@ Expand Down @@