DTPPSDK-1216: Add cookie disabling flag to logger call 🍪 (#156)

* add disableSetCookie global variable * add globals * remove dist * add query to logger * make test global variable boolean * change to camel case --------- Co-authored-by: Spencer Sablan <[email protected]>
paypal · Jun 12, 2023 · db81201 · db81201
1 parent dec994b
commit db81201
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -21,5 +21,8 @@ module.exports = {
     __FUNDING_ELIGIBILITY__: true,
     __PAYPAL_DOMAIN__: true,
     __PAYPAL_API_DOMAIN__: true,
+
+    // Experiment Variable
+    __DISABLE_SET_COOKIE__: true,
   },
 };
diff --git a/src/declarations.js b/src/declarations.js
@@ -30,3 +30,6 @@ declare var __COMPONENTS__: $ReadOnlyArray<$Values<typeof COMPONENTS>>;
 
 // $FlowFixMe[value-as-type]
 declare var __FUNDING_ELIGIBILITY__: FundingEligibilityType;
+
+// Experiment Variable
+declare var __DISABLE_SET_COOKIE__: boolean;
diff --git a/src/global.js b/src/global.js
@@ -110,3 +110,8 @@ export function getFundingEligibility(): FundingEligibilityType {
 export function getPlatform(): $Values<typeof PLATFORM> {
   return isDevice() ? PLATFORM.MOBILE : PLATFORM.DESKTOP;
 }
+
+// Experiment Variable
+export function getDisableSetCookie(): boolean {
+  return __DISABLE_SET_COOKIE__;
+}
diff --git a/src/logger.js b/src/logger.js
@@ -3,12 +3,19 @@
 import { Logger, type LoggerType } from "@krakenjs/beaver-logger/src";
 import { memoize } from "@krakenjs/belter/src";
 
+import { getDisableSetCookie } from "./global";
 import { getPayPalLoggerUrl } from "./domains";
 
 type GetLogger = () => LoggerType;
 
+const disableSetCookieQuery = "disableSetCookie=true";
+
+const loggerUrl = getDisableSetCookie()
+  ? `${getPayPalLoggerUrl()}?${disableSetCookieQuery}`
+  : getPayPalLoggerUrl();
+
 export const getLogger: GetLogger = memoize(() => {
   return Logger({
-    url: getPayPalLoggerUrl(),
+    url: loggerUrl,
   });
 });
diff --git a/test/globals.js b/test/globals.js
@@ -1,7 +1,7 @@
 /* @flow */
 
 type TestGlobals = {|
-  [string]: string | number | (() => string | (() => number)),
+  [string]: string | number | boolean | (() => string | (() => number)),
   __COMPONENTS__: $ReadOnlyArray<string>,
 |};
 
@@ -19,4 +19,5 @@ export const sdkClientTestGlobals: TestGlobals = {
   __PAYPAL_DOMAIN__: "mock://www.paypal.com",
   __PAYPAL_API_DOMAIN__: "mock://msmaster.qa.paypal.com",
   __COMPONENTS__: ["buttons"],
+  __DISABLE_SET_COOKIE__: true,
 };