Decode the sdk meta if url encoded meta is passed #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 20 20
Lines 489 489
Branches 40 40
=======================================
Hits 430 430
Misses 59 59
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
wsbrunson
approved these changes
Sep 15, 2023
src/tracking.js
Outdated
| @@ -114,7 +114,7 @@ export function setupLogger() { | |||
| // https://www.paypal.com/us/gifts/ | |||
| const isLoadedInFrame = isPayPalDomain() && window.xprops; | |||
| const sdkLoadTime = | |||
| typeof loadTime === "number" ? loadTime.toString() : undefined; | |||
| typeof loadTime === "number" ? Number(loadTime) : undefined; | |||
There was a problem hiding this comment.
isn't loadTime already a number in this case? since typeof loadtime === "numer" is true?
wsbrunson
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode SDK meta if the meta is passed as URL encoded value.