Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK token for PayPal domain #172

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Add SDK token for PayPal domain #172

merged 2 commits into from
Dec 5, 2023

Conversation

elizabethmv
Copy link
Contributor

@elizabethmv elizabethmv commented Dec 4, 2023

Restricting to PayPal domains for now, we will remove/add merchant domains in phases for Alpha/GA

@elizabethmv elizabethmv requested a review from a team as a code owner December 4, 2023 21:26
@elizabethmv elizabethmv requested a review from wsbrunson December 4, 2023 21:27
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6e1ad20) 87.93% compared to head (c33c00a) 87.75%.
Report is 2 commits behind head on main.

❗ Current head c33c00a differs from pull request most recent head c75e1aa. Consider uploading reports for the commit c75e1aa to get more accurate results

Files Patch % Lines
src/script.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   87.93%   87.75%   -0.18%     
==========================================
  Files          20       20              
  Lines         489      490       +1     
  Branches       40       40              
==========================================
  Hits          430      430              
- Misses         59       60       +1     
Flag Coverage Δ
client 83.73% <0.00%> (-0.23%) ⬇️
server 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/script.js Outdated
@@ -338,6 +339,10 @@ export function getUserExperienceFlow(): ?string {
return getSDKAttribute(SDK_SETTINGS.USER_EXPERIENCE_FLOW);
}

export function getSDKToken(): ?string {
return isPayPalDomain() ? getSDKAttribute(SDK_SETTINGS.SDK_TOKEN) : "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should actually remove this check so that the axo project can start using this value too. They are about to go live with a merchant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'll get this removed

@elizabethmv elizabethmv merged commit 81e830c into main Dec 5, 2023
1 check passed
@elizabethmv elizabethmv deleted the add-sdk-token branch December 5, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants