add DPoP createJWT and buildDPoPHeaders function #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 72.40% 73.66% +1.25%
==========================================
Files 23 23
Lines 1939 2035 +96
Branches 236 240 +4
==========================================
+ Hits 1404 1499 +95
- Misses 525 526 +1
Partials 10 10 ☔ View full report in Codecov by Sentry. |
jshawl
changed the title
nikrom17
approved these changes
Feb 21, 2024
alphabetize import and clarify base64 test case add createJWT function add buildDPoPHeaders function and export it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up PR to #186 and is the last of the DPoP related changes in sdk-client.
This PR implements the JWT creation and signature and exports a single method to consumers of this package,
buildDPoPHeaders, that abstracts away all of the lower-level cryptographic and encoding related functionality.