Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use node version from .nvmrc in ci #189

Merged
merged 1 commit into from
Feb 22, 2024
Merged

use node version from .nvmrc in ci #189

merged 1 commit into from
Feb 22, 2024

Conversation

jshawl
Copy link
Contributor

@jshawl jshawl commented Feb 22, 2024

This PR fixes an issue where pull requests are tested using node 16 but npm publish actions are tested using node 18.

I copied over the yaml from publish.yml:

- name: ⎔ Setup node
# sets up the .npmrc file to publish to npm
uses: actions/setup-node@v3
with:
node-version: ${{ env.NVMRC }}

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.66%. Comparing base (4b87e82) to head (f39535c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   73.66%   73.66%           
=======================================
  Files          23       23           
  Lines        2035     2035           
  Branches      240      240           
=======================================
  Hits         1499     1499           
  Misses        526      526           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jshawl jshawl marked this pull request as ready for review February 22, 2024 20:24
@jshawl jshawl requested a review from a team as a code owner February 22, 2024 20:24
Copy link
Member

@wsbrunson wsbrunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jshawl jshawl merged commit 6f0e7cc into main Feb 22, 2024
5 checks passed
@jshawl jshawl deleted the use-node-18-ci branch February 22, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants