Fix for incorrect metric causing high cardinality

[sioked]

The isLoadedInFrame variable previously was isPayPalDomain() && window.xprops. Because of the && operator, the value here would be the value of window.xprops which is a very high cardinality value. We ended up having metrics disabled due to the cardinality of these events so casting to a Boolean should solve for that.

One thing I'm not clear on is why we're mapping isLoadedInFrame to isPayPalDomain and not calling isPayPalDomain() directly, but I'm only trying to solve the cardinality issue on this event.

[elizabethmv]

I'm not sure if this is still the case but we've seen in the past signalFX dropping boolean values. Should we make sure this is a true/false string or some other string value?

[sioked]

Good observation! I wasn't aware of that - I'll change this to a string

[jshawl]

I like the change (after the lint fix) but wanted to propose an optional/additional change in beaver-logger around https://github.com/krakenjs/beaver-logger/blob/87749c48788dfd2525fb9b075ca33a7bf69d3311/src/logger.js#L296-L301

that limits the max cardinality value (truncate and console.warn maybe?)

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.28%. Comparing base (6ce78b2) to head (b3d1ca0).
Report is 1 commits behind head on main.

Files	Patch %	Lines
src/tracking.js	16.66%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   73.74%   74.28%   +0.54%     
==========================================
  Files          23       23              
  Lines        2045     2030      -15     
  Branches      241      239       -2     
==========================================
  Hits         1508     1508              
+ Misses        527      512      -15     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sioked]

@jshawl I would love to find a way to validate/limit the cardinality in beaver logger. We could look at the length of the string as a possible indicator, but it is possible to have low cardinality across all of the metrics while also having a long string length. Do you have any thoughts or ideas?