Hardcode library values #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 74.28% 74.41% +0.12%
==========================================
Files 23 23
Lines 2030 2040 +10
Branches 239 241 +2
==========================================
+ Hits 1508 1518 +10
Misses 512 512
Partials 10 10 ☔ View full report in Codecov by Sentry. |
jshawl
reviewed
Mar 15, 2024
| const mockElement = makeMockScriptElement(mockScriptSrc); | ||
| mockElement.setAttribute(SDK_SETTINGS.JS_SDK_LIBRARY, jsSdkLibrary); | ||
| // $FlowIgnore | ||
| getCurrentScript.mockReturnValue(mockElement); | ||
|
|
||
| expect(getJsSdkLibrary()).toEqual(jsSdkLibrary); | ||
| expect(getJsLibrary()).toEqual(jsSdkLibrary); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@gregjopa, @westeezy, and I had a solid chat about DTPPCPSDK-1482 where it was decided we'd remove
JS_SDK_LIBRARIESfrom@paypal/sdk-constantsand hardcode values. This was inspired by the difficulty of adding@paypal/sdk-constantsas a dependency ofpaypal-js. Additionally, it was decided that"none"was a better value than"raw-script"for when a library isn't being used to load the JS SDK.