Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) loadV4 sdk loader loads latest checkout.js #207

Closed
wants to merge 4 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@paypal/sdk-client",
"version": "4.0.189",
"version": "4.0.190-alpha.0",
"description": "Shared config between PayPal/Braintree.",
"main": "index.js",
"scripts": {
2 changes: 1 addition & 1 deletion server/meta.jsx
Original file line number Diff line number Diff line change
@@ -356,7 +356,7 @@ export function unpackSDKMeta(sdkMeta?: string): SDKMeta {
return;
}
if (version === '4' || version === 'latest') {
if (version === 'latest' || version.charAt(0) === '4') {
version = '';
}
2 changes: 1 addition & 1 deletion server/meta.test.js
Original file line number Diff line number Diff line change
@@ -809,7 +809,7 @@ test("should construct a valid minified loader even when no url passed", () => {
});

test("should construct a valid version loader even when no url passed", () => {
const sdkUrl = "https://www.paypalobjects.com/api/checkout.4.0.435.js";
const sdkUrl = "https://www.paypalobjects.com/api/checkout.js";

const { getSDKLoader } = unpackSDKMeta();