keep v4 patch versions at 132 or above #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
commented
Jun 18, 2024
Comment on lines
+70
to
+89
| { | ||
| windowName: "xcomponent__ppcheckout__4_0_1__abc12345", | ||
| expected: "https://www.paypalobjects.com/api/checkout.4.0.132.js", | ||
| }, | ||
| { | ||
| windowName: "xcomponent__ppcheckout__4_0_65__abc12345", | ||
| expected: "https://www.paypalobjects.com/api/checkout.4.0.132.js", | ||
| }, | ||
| { | ||
| windowName: "xcomponent__ppcheckout__4_0_131__abc12345", | ||
| expected: "https://www.paypalobjects.com/api/checkout.4.0.132.js", | ||
| }, | ||
| { | ||
| windowName: "xcomponent__ppcheckout__4_0_132__abc12345", | ||
| expected: "https://www.paypalobjects.com/api/checkout.4.0.132.js", | ||
| }, | ||
| { | ||
| windowName: "xcomponent__ppcheckout__4_0_133__abc12345", | ||
| expected: "https://www.paypalobjects.com/api/checkout.4.0.133.js", | ||
| }, |
There was a problem hiding this comment.
Here are the tests that matter
cspalevic
reviewed
Jun 18, 2024
cspalevic
approved these changes
Jun 20, 2024
imbrian
approved these changes
Jun 20, 2024
wsbrunson
added a commit
that referenced
this pull request
Jun 20, 2024
This reverts commit ecbc2f9.
wsbrunson
added a commit
that referenced
this pull request
Jun 20, 2024
|
i just realized we want to wait to merge this until we make the edge routing changes: #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description in slack