-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#760 Migrate from Akka to Pekko #762
Conversation
squbs-ext/src/main/scala/org/squbs/marshallers/json/JacksonMapperSupport.scala
Outdated
Show resolved
Hide resolved
This is great but I don't see any CI build results here. Can we setup a CI build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to see build results. There are still some TODOs
JacksonSupport.unmarshaller[T](tt, mapper[T]) | ||
implicit val objectMapper = mapper[T] | ||
implicit val javaType = objectMapper.constructType(classTag.runtimeClass) | ||
JacksonSupport.unmarshaller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a TODO here.
Thanks for your pull request. Please review the following guidelines.