String and number path param validation #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 99.14% 98.95% -0.20%
==========================================
Files 19 19
Lines 1174 1151 -23
==========================================
- Hits 1164 1139 -25
- Misses 10 12 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'll add the test to cover that case |
emilien-puget
commented
Mar 4, 2024
|
@daveshanley i pushed the proposed changes, with those changes we got more precise errors when a bad path parameter is given during a validation context |
|
Would you be able to rebase? |
Of course, I'll do that |
emilien-puget
force-pushed
the
path_param_validation
branch
3 times, most recently
from
4f4a66e
to
56c3b8b
Compare
|
@daveshanley rebased and squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR depends on #55 for the validateSimpleParam function
it should fix #43