Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added base path stripping for the request path during path parameter … #59

Conversation

jacobm-splunk
Copy link
Contributor

Path parameter validation did not properly strip the base path from the request path when doing parameter validation.

If the server had a non-null postfix path, then the incorrect parameter would be validated.

I added a test to exercise this scenario to ensure this shouldn't happen again.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (3397867) to head (e4974f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   98.95%   98.96%           
=======================================
  Files          19       19           
  Lines        1151     1156    +5     
=======================================
+ Hits         1139     1144    +5     
  Misses         12       12           
Flag Coverage Δ
unittests 98.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley daveshanley merged commit f866c7b into pb33f:main Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants