Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with race conditions in test further up the stack. #66

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

daveshanley
Copy link
Member

A race condition in vacuum is thrown during tests, this slight change fixes that by swapping over to a channel vs a timeout.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (f866c7b) to head (31d929f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   98.96%   99.71%   +0.75%     
==========================================
  Files          19       19              
  Lines        1156     1737     +581     
==========================================
+ Hits         1144     1732     +588     
+ Misses         12        5       -7     
Flag Coverage Δ
unittests 99.71% <100.00%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley daveshanley merged commit 6035624 into main Apr 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant