Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and handle compiler err on compile req body #69

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

martinsirbe
Copy link
Contributor

This pull request introduces improved error handling for the JSON schema compilation process in the request validation logic. Previously, the code did not handle potential errors from the compiler, which caused the code to panic when attempting to validate the request body.

The change will improve reliability by ensuring that schema compilation errors are gracefully handled, thus improving the stability of the request body schema validation process.
Additionally, this will facilitate quicker debugging and resolution of issues related to invalid schemas.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (688b7a2) to head (d39c59d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          19       19           
  Lines        1744     1753    +9     
=======================================
+ Hits         1739     1748    +9     
  Misses          5        5           
Flag Coverage Δ
unittests 99.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley
Copy link
Member

Thanks for the upgrade, can you add a test to trigger the new code branch so coverage does not drop?

@martinsirbe martinsirbe force-pushed the handle-err-on-compile-req-body branch from edbf27a to cef2edd Compare April 26, 2024 16:17
@martinsirbe martinsirbe force-pushed the handle-err-on-compile-req-body branch from cef2edd to 41cb2de Compare April 26, 2024 16:22
@daveshanley daveshanley merged commit 5b5766b into pb33f:main Apr 28, 2024
3 checks passed
@martinsirbe martinsirbe deleted the handle-err-on-compile-req-body branch April 28, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants