Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindPath reports path and operation not found #72

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

emilien-puget
Copy link
Contributor

@emilien-puget emilien-puget commented Apr 28, 2024

The idea is to have a more precise error reporting from the FindPath function, before it could yield a path not found validation error, with this proposed change we will have a path not found or operation not found error.

this may be a breaking change for some implementation that were reliant on IsPathMissingError to filter any error regarding a find path validation error

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (5e5b19b) to head (8318405).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   99.71%   99.64%   -0.07%     
==========================================
  Files          19       19              
  Lines        1758     1703      -55     
==========================================
- Hits         1753     1697      -56     
- Misses          5        6       +1     
Flag Coverage Δ
unittests 99.64% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley
Copy link
Member

I think we may need to bump this to a feature release as it's a breaking change, a small one, but a break in previous behavior.

@emilien-puget
Copy link
Contributor Author

Indeed, do you have in mind some helpers function to ease the update that we could add?

@daveshanley
Copy link
Member

I don't know what kind of helper functions we could add to be honest, it's a change in strategy on path validation (albeit a small one).

@daveshanley
Copy link
Member

we can bundle both your PRs into a minor release.

@emilien-puget
Copy link
Contributor Author

That'd be great

@daveshanley daveshanley merged commit 8c66162 into pb33f:main Jul 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants