Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use google/uuid rather than twinj/uuid #141

Merged
merged 1 commit into from
May 20, 2024

Conversation

Xtansia
Copy link
Contributor

@Xtansia Xtansia commented May 20, 2024

https://github.com/twinj/uuid was last updated in 2017 and has been archived since 2020.

Additionally twinj/uuid pulls in a non-existent github.com/myesui/uuid which causes go mod download to fail.

https://github.com/twinj/uuid was last updated in 2017 and has been archived since 2020.

Additionally `twinj/uuid` pulls in a non-existent `github.com/myesui/uuid` which causes `go mod download` to fail.
@Xtansia Xtansia force-pushed the fix/use-google-uuid branch from 40fa6e3 to 4da6a19 Compare May 20, 2024 00:41
Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure how that UUID implementation made it in there, must have been an oversight as our other projects all use the google implementation also.

@daveshanley daveshanley merged commit 1b853b6 into pb33f:main May 20, 2024
2 checks passed
@Xtansia Xtansia deleted the fix/use-google-uuid branch May 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants