Issue Fix: Issue 165 - isAdmin state is moved to zustand store and associated functionality is changed #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sociated functions are changed
akashsinghvance
suggested changes
Jan 29, 2025
|
Removed all the unwanted comments from the code base and also attaching a video showcasing the admin functionality. PB-isAdmin-Functionality.1.mp4 |
SkySingh04
requested changes
Feb 2, 2025
app/(default)/hustle/page.tsx
Outdated
| setIsAdmin(isAdmin); | ||
| setIsAdminLoggedIn(true); | ||
| setAdmin(isAdmin); | ||
| setAdmin(true); |
There was a problem hiding this comment.
redundant code, setting it to isAdmin and then again to true
| } catch (error) { | ||
| console.error("Error checking admin status:", error); | ||
| setIsAdmin(false); | ||
| setIsAdminLoggedIn(false); | ||
| setAdmin(false); |
There was a problem hiding this comment.
redundant code, setting it to isAdmin and then again to false
| } | ||
| }; | ||
|
|
||
| const unsubscribe = onAuthStateChanged(auth, (user) => { | ||
| if (user) { | ||
| checkAdmin(user.uid); | ||
| } else { | ||
| setIsAdmin(false); | ||
| setIsAdminLoggedIn(false); | ||
| setAdmin(false); |
| @@ -1,5 +1,9 @@ | |||
| "use client"; | |||
|
|
|||
|
|
|||
| import { useStore } from "@/lib/zustand/store"; | |||
|
|
|||
components/ui/header.tsx
Outdated
|
|
||
| reset(); | ||
| } | ||
| ======= |
There was a problem hiding this comment.
why is the ==== here? maybe the merge wasnt done properly
|
Crazy work! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: What does this PR do?
Which issue(s) this PR fixes
Changes Made
Describe the changes you've made in this PR:
Type of Change
How Has This Been Tested?
Describe the tests you ran:
Please describe the test cases and expected behavior:
Screenshots (if applicable)
Dependencies
Documentation
Comments:
Reviewer Notes