Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add removal of start/end brackets around IPv6 addresses #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

delfuego
Copy link

Many proxies (e.g., IIS) add start/end brackets around IPv6 addresses in the X-Forwarded-For header, which prevents request-ip from being able to see them there since that fails the is.ip IPv6 regex test; this removes them if they're there.

This uses functions that have been in Javascript since time immemorial (string.startsWith, string.endsWith, string.substring), and all tests continue to pass.

many proxies add start/end brackets around IPv6 addresses in the X-Forwarded-For header; remove them if they're there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant