Writer returns number of input bytes consumed, not output bytes written. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the contract of `io.Writer`. Similar for `WriteString`. Functions that *only* output SGR escapes no longer return the number of bytes written. In addition to adding implementation complexity (they can't be written in terms of `Write()`), the inconsistency in return values would be confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the contract of
io.Writer. Similar forWriteString.Functions that only output SGR escapes no longer return the number of
bytes written. In addition to adding implementation complexity (they
can't be written in terms of
Write()), the inconsistency in returnvalues would be confusing.
Fixes #1.