title: simplify youtube parsing #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `youtube_title` only use regex to extract the embedded JSON. Then use the stdlib's actual JSON parser from there. This avoids some unescaping quirks and generally feels less brittle. We now disregard `<title>` entirely since we already were relying on JSON's presence for the channel name. So we might as well use it up front for the video name too.
|
LGTM. TYFYS. o7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
youtube_titleonly use regex to extract the embedded JSON. Then use the stdlib's actual JSON parser from there. This avoids some unescaping quirks and generally feels less brittle. We now disregard<title>entirely since we already were relying on JSON's presence for the channel name. So we might as well use it up front for the video name too.