-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LasBasler User Presets #1328
Open
aberges-SLAC
wants to merge
9
commits into
pcdshub:master
Choose a base branch
from
aberges-SLAC:LasBasler_user_presets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LasBasler User Presets #1328
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
40c4caf
ENH: Add UserSet signals and add long_names
aberges-SLAC 6ce08bd
Merge branch 'pcdshub:master' into LasBasler_user_presets
aberges-SLAC b2a90da
DOC: add release doc
aberges-SLAC cf3fc9c
Merge branch 'master' into LasBasler_user_presets
aberges-SLAC 81cbeae
MNT: nitpick some release notes
aberges-SLAC 0cd8c7f
Merge branch 'LasBasler_user_presets' of github.com:aberges-SLAC/pcds…
aberges-SLAC 3344788
MNT: change preset to settings for name deconflict
aberges-SLAC 20839a4
Update docs/source/upcoming_release_notes/1327-LasBasler_User_Presets…
aberges-SLAC e2b19f7
Merge branch 'master' into LasBasler_user_presets
aberges-SLAC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
docs/source/upcoming_release_notes/1327-LasBasler_User_Presets.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
1327 LasBasler User Presets | ||
################# | ||
|
||
API Breaks | ||
---------- | ||
- N/A | ||
|
||
Library Features | ||
---------------- | ||
- N/A | ||
|
||
Device Features | ||
--------------- | ||
- LasBasler: Adds long_names to signals | ||
- LasBasler: Adds `save_setting` and `load_setting` signals for saving and loading settings | ||
|
||
New Devices | ||
----------- | ||
- N/A | ||
|
||
Bugfixes | ||
-------- | ||
- N/A | ||
|
||
Maintenance | ||
----------- | ||
- N/A | ||
|
||
Contributors | ||
------------ | ||
- aberges-SLAC |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of these long name updates just a ride-along update for readability, or are they related to the user set stuff somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both. Ride-along for better general readability and also for clarity on the newly added signals.