-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add sortable/filterable table inspired by pmps-ui #67
Conversation
This is collecting dust. I'm going to make the tests pass, ask for a review, merge, and move the rest of the todo items into an issue. |
A big uncommitted comment block I found on my NFS clone, I must have been trying to figure out the remaining bullet points:
|
Seems to still work using the TMO screen, though the performance isn't great when you have a lot of items and/or ask for new sorts. |
Created #70 with follow-up information |
This closes #69 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't consider what might be contained in your follow-up PR, but only what I saw in this PR.
All suggestions are minor and just code smell / potential bug-related.
Regardless of that, the functionality the widget provides is really nice. I expect we'll be able to use it for atef and other projects.
Oh man, sorry this is so messy. I'll have to come back to this one before merging I guess... it's really awkward because it's deployed as-is in dev. |
I don't think any of what I suggested are really so bad, but rather have places for easy improvements. I'd be totally OK with merging/tagging and letting you circle back to this if/when you get time. |
I kind of disagree, I don't like to compromise on code quality. The important thing to cut off here to ensure it gets merged is the scope, not the small tweaks. |
Ok, this PR next. To-do:
|
Co-authored-by: Ken Lauer <[email protected]>
Co-authored-by: Ken Lauer <[email protected]>
Co-authored-by: Ken Lauer <[email protected]>
Co-authored-by: Ken Lauer <[email protected]>
I think I've gotten all the biggest fixes done. I'm going to merge this and move on. |
Description
Add the
FilterSortWidgetTable
widget. This widget allows us to repeat a template generically in a table form, and handle things like sorting and filtering in a re-usable way.Here's a screenshot of the TMO screen I am working on that uses this widget:
Features:
Motivation and Context
This is a common motif and we should be able to re-use it in multiple contexts
How Has This Been Tested?
Only interactiveley so far
Where Has This Been Documented?
Only docstrings so far