Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add program to calculate factorial in Python #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add program to calculate factorial in Python #53

wants to merge 1 commit into from

Conversation

Mahir-G
Copy link
Contributor

@Mahir-G Mahir-G commented Oct 11, 2018

Resolve issue #41

sagar-kalra
sagar-kalra requested changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@sagar-kalra sagar-kalra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the significance of 2nd commit?

divyam3897
divyam3897 requested changes Oct 14, 2018
View reviewed changes
programs/factorial.py Outdated
else:
for i in range(1,num + 1):
factorial = factorial*i
print("The factorial of",num,"is",factorial)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after ","

programs/factorial.py Outdated
# Python program to find the factorial of a number provided by the user.

# change the value for a different result
num = 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hard coded num

@Mahir-G
Copy link
Contributor Author

Mahir-G commented Oct 14, 2018

kindly review it now.

divyam3897
divyam3897 requested changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@divyam3897 divyam3897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Program is to be added in language folder not programs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyam3897 divyam3897 divyam3897 requested changes

@sagar-kalra sagar-kalra sagar-kalra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mahir-G @divyam3897 @sagar-kalra